Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2856593002:
Update a host_resolver()->AddRule in chrome/browser that I missed earlier. (Closed)
|
Created:
3 years, 7 months ago by jam Modified:
3 years, 7 months ago Reviewers:
Ken Rockot(use gerrit already) CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate a host_resolver()->AddRule in chrome/browser that I missed earlier.
Part 3/2.
BUG=713847
Review-Url: https://codereview.chromium.org/2856593002
Cr-Commit-Position: refs/heads/master@{#468432}
Committed: https://chromium.googlesource.com/chromium/src/+/a9cfcb53166c1ad54a7c8d07e205b13b970b2b93
Patch Set 1 : fix #
Messages
Total messages: 19 (15 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== test BUG= ========== to ========== Update a host_resolver()->AddRules in chrome/browser that I missed earlier. Part 3/2. BUG=713847 ==========
jam@chromium.org changed reviewers: + rockot@chromium.org
lgtm
Description was changed from ========== Update a host_resolver()->AddRules in chrome/browser that I missed earlier. Part 3/2. BUG=713847 ========== to ========== Update a host_resolver()->AddRule in chrome/browser that I missed earlier. Part 3/2. BUG=713847 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493674988288830,
"parent_rev": "920c268621477bdfa16464d0b8ef915703eacb00", "commit_rev":
"a9cfcb53166c1ad54a7c8d07e205b13b970b2b93"}
Message was sent while issue was closed.
Description was changed from ========== Update a host_resolver()->AddRule in chrome/browser that I missed earlier. Part 3/2. BUG=713847 ========== to ========== Update a host_resolver()->AddRule in chrome/browser that I missed earlier. Part 3/2. BUG=713847 Review-Url: https://codereview.chromium.org/2856593002 Cr-Commit-Position: refs/heads/master@{#468432} Committed: https://chromium.googlesource.com/chromium/src/+/a9cfcb53166c1ad54a7c8d07e205... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a9cfcb53166c1ad54a7c8d07e205... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
