Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2856553002: Cleanup determining ibeam for node. (Closed)

Created:
3 years, 7 months ago by dtapuska
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Cleanup determining ibeam for node. Change https://chromium.googlesource.com/chromium/src/+/d892f9592860691ae9a782c12260c94ed6bd1a63%5E%21/#F30 caused the layout object to possibly be invalidated. Collapse the code so that LayoutObject is correclty scoped so we don't run this risk. BUG=712459 Review-Url: https://codereview.chromium.org/2849883002 Cr-Commit-Position: refs/heads/master@{#468045} (cherry picked from commit 9d6b6c40b933564260a0a70567b90ac30656222a) Review-Url: https://codereview.chromium.org/2856553002 . Cr-Commit-Position: refs/branch-heads/3071@{#318} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1dcdc127c1463d62c3e57a260e5a03869eab6024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M third_party/WebKit/Source/core/input/EventHandler.cpp View 3 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
3 years, 7 months ago (2017-05-01 13:51:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dcdc127c1463d62c3e57a260e5a03869eab6024.

Powered by Google App Engine
This is Rietveld 408576698