Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2856503002: Web Animations: Use PlaybackDirection enum in AnimationEffectTiming.idl (Closed)

Created:
3 years, 7 months ago by Eric Willigers
Modified:
3 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Use PlaybackDirection enum in AnimationEffectTiming.idl AnimationEffectTiming.idl and AnimationEffectTimingReadOnly.idl now use attribute PlaybackDirection direction; for consistency with the spec. https://w3c.github.io/web-animations/#the-animationeffecttiming-interface https://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface BUG=716963 Review-Url: https://codereview.chromium.org/2856503002 Cr-Commit-Position: refs/heads/master@{#468295} Committed: https://chromium.googlesource.com/chromium/src/+/9c5604209f8fc4438c7e141696089c3d2985928b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationEffectTiming.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Eric Willigers
3 years, 7 months ago (2017-05-01 04:32:37 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm as long as this works without repeating the definition of PlaybackDirection (I'm not sure ...
3 years, 7 months ago (2017-05-01 04:38:08 UTC) #5
Eric Willigers
On 2017/05/01 04:38:08, suzyh_UTC10 wrote: > lgtm as long as this works without repeating the ...
3 years, 7 months ago (2017-05-01 05:43:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856503002/1
3 years, 7 months ago (2017-05-01 06:16:51 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 06:21:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c5604209f8fc4438c7e14169608...

Powered by Google App Engine
This is Rietveld 408576698