Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2856463003: [blink_perf] Add log messages for tracing metrics in blink_perf (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[blink_perf] Add log messages for tracing metrics in blink_perf We add the following log messages: * Error message when one of tracingCategories & traceEventsToMeasure is specified but not the other. * Hint users to use tools/perf/run_benchmark to get tracing based metrics BUG=701059 Review-Url: https://codereview.chromium.org/2856463003 Cr-Commit-Position: refs/heads/master@{#468332} Committed: https://chromium.googlesource.com/chromium/src/+/837b0ae2aa5d5755b995951575c3c57ee96f76fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M third_party/WebKit/PerformanceTests/resources/runner.js View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
nednguyen
3 years, 7 months ago (2017-05-01 15:26:59 UTC) #2
Xianzhu
lgtm
3 years, 7 months ago (2017-05-01 15:58:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856463003/1
3 years, 7 months ago (2017-05-01 15:59:15 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 16:59:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/837b0ae2aa5d5755b995951575c3...

Powered by Google App Engine
This is Rietveld 408576698