Issue 285643008: Revert PropertyCallbackInfo::This() signature change from r21022.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 285643008: Revert PropertyCallbackInfo::This() signature change from r21022. (Closed)

Created:
6 years, 7 months ago by Sven Panne

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert PropertyCallbackInfo::This() signature change from r21022. This exposed an internal implementation detail, which could be handled differently. BUG=v8:3274 LOG=y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21297

Created: 6 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+20 lines, -10 lines)
	M	include/v8.h	View	2 chunks	+3 lines, -3 lines	0 comments
	M	src/accessors.cc	View	8 chunks	+17 lines, -7 lines	0 comments

Total messages: 3 (0 generated)

Sven Panne

6 years, 7 months ago (2014-05-14 08:34:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21297 (presubmit successful).