Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: include/v8.h

Issue 285643008: Revert PropertyCallbackInfo::This() signature change from r21022. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** \mainpage V8 API Reference Guide 5 /** \mainpage V8 API Reference Guide
6 * 6 *
7 * V8 is Google's open source JavaScript engine. 7 * V8 is Google's open source JavaScript engine.
8 * 8 *
9 * This set of documents provides reference material generated from the 9 * This set of documents provides reference material generated from the
10 * V8 header file, include/v8.h. 10 * V8 header file, include/v8.h.
(...skipping 2479 matching lines...) Expand 10 before | Expand all | Expand 10 after
2490 2490
2491 /** 2491 /**
2492 * The information passed to a property callback about the context 2492 * The information passed to a property callback about the context
2493 * of the property access. 2493 * of the property access.
2494 */ 2494 */
2495 template<typename T> 2495 template<typename T>
2496 class PropertyCallbackInfo { 2496 class PropertyCallbackInfo {
2497 public: 2497 public:
2498 V8_INLINE Isolate* GetIsolate() const; 2498 V8_INLINE Isolate* GetIsolate() const;
2499 V8_INLINE Local<Value> Data() const; 2499 V8_INLINE Local<Value> Data() const;
2500 V8_INLINE Local<Value> This() const; 2500 V8_INLINE Local<Object> This() const;
2501 V8_INLINE Local<Object> Holder() const; 2501 V8_INLINE Local<Object> Holder() const;
2502 V8_INLINE ReturnValue<T> GetReturnValue() const; 2502 V8_INLINE ReturnValue<T> GetReturnValue() const;
2503 // This shouldn't be public, but the arm compiler needs it. 2503 // This shouldn't be public, but the arm compiler needs it.
2504 static const int kArgsLength = 6; 2504 static const int kArgsLength = 6;
2505 2505
2506 protected: 2506 protected:
2507 friend class MacroAssembler; 2507 friend class MacroAssembler;
2508 friend class internal::PropertyCallbackArguments; 2508 friend class internal::PropertyCallbackArguments;
2509 friend class internal::CustomArguments<PropertyCallbackInfo>; 2509 friend class internal::CustomArguments<PropertyCallbackInfo>;
2510 static const int kHolderIndex = 0; 2510 static const int kHolderIndex = 0;
(...skipping 3965 matching lines...) Expand 10 before | Expand all | Expand 10 after
6476 } 6476 }
6477 6477
6478 6478
6479 template<typename T> 6479 template<typename T>
6480 Local<Value> PropertyCallbackInfo<T>::Data() const { 6480 Local<Value> PropertyCallbackInfo<T>::Data() const {
6481 return Local<Value>(reinterpret_cast<Value*>(&args_[kDataIndex])); 6481 return Local<Value>(reinterpret_cast<Value*>(&args_[kDataIndex]));
6482 } 6482 }
6483 6483
6484 6484
6485 template<typename T> 6485 template<typename T>
6486 Local<Value> PropertyCallbackInfo<T>::This() const { 6486 Local<Object> PropertyCallbackInfo<T>::This() const {
6487 return Local<Value>(reinterpret_cast<Value*>(&args_[kThisIndex])); 6487 return Local<Object>(reinterpret_cast<Object*>(&args_[kThisIndex]));
6488 } 6488 }
6489 6489
6490 6490
6491 template<typename T> 6491 template<typename T>
6492 Local<Object> PropertyCallbackInfo<T>::Holder() const { 6492 Local<Object> PropertyCallbackInfo<T>::Holder() const {
6493 return Local<Object>(reinterpret_cast<Object*>(&args_[kHolderIndex])); 6493 return Local<Object>(reinterpret_cast<Object*>(&args_[kHolderIndex]));
6494 } 6494 }
6495 6495
6496 6496
6497 template<typename T> 6497 template<typename T>
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
6618 */ 6618 */
6619 6619
6620 6620
6621 } // namespace v8 6621 } // namespace v8
6622 6622
6623 6623
6624 #undef TYPE_CHECK 6624 #undef TYPE_CHECK
6625 6625
6626 6626
6627 #endif // V8_H_ 6627 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698