Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: chrome/browser/permissions/permission_request_manager.h

Issue 2856413002: Remove unused HasUserGestureRequest and unneeded request_url_ in PermissionRequestManager (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_request_manager.h
diff --git a/chrome/browser/permissions/permission_request_manager.h b/chrome/browser/permissions/permission_request_manager.h
index b2df0b9d08a0a07172227246d1df40568b7ba35b..872fd8f50d2ba2a54f8558a69a80598a4e1eae53 100644
--- a/chrome/browser/permissions/permission_request_manager.h
+++ b/chrome/browser/permissions/permission_request_manager.h
@@ -163,10 +163,6 @@ class PermissionRequestManager
// request may or may not be the same object as |request|.
PermissionRequest* GetExistingRequest(PermissionRequest* request);
- // Returns true if |queue| contains a request which was generated by a user
- // gesture. Returns false otherwise.
- bool HasUserGestureRequest(const std::vector<PermissionRequest*>& queue);
-
// Calls PermissionGranted on a request and all its duplicates.
void PermissionGrantedIncludingDuplicates(PermissionRequest* request);
// Calls PermissionDenied on a request and all its duplicates.
@@ -194,9 +190,6 @@ class PermissionRequestManager
std::unordered_multimap<PermissionRequest*, PermissionRequest*>
duplicate_requests_;
- // URL of the main frame in the WebContents to which this manager is attached.
- // TODO(gbillock): if there are iframes in the page, we need to deal with it.
- GURL request_url_;
bool main_frame_has_fully_loaded_;
// Whether the response to each request should be persisted.
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698