Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: chrome/browser/permissions/permission_request_manager.cc

Issue 2856413002: Remove unused HasUserGestureRequest and unneeded request_url_ in PermissionRequestManager (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_request_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_request_manager.cc
diff --git a/chrome/browser/permissions/permission_request_manager.cc b/chrome/browser/permissions/permission_request_manager.cc
index 2a7cf3ac5729cd357ac67051284a3872ce8cc374..93a9794d448bcede889af32354e1d8fa9bf0edc4 100644
--- a/chrome/browser/permissions/permission_request_manager.cc
+++ b/chrome/browser/permissions/permission_request_manager.cc
@@ -113,7 +113,7 @@ void PermissionRequestManager::AddRequest(PermissionRequest* request) {
// any other renderer-side nav initiations?). Double-check this for
// correct behavior on interstitials -- we probably want to basically queue
// any request for which GetVisibleURL != GetLastCommittedURL.
- request_url_ = web_contents()->GetLastCommittedURL();
+ const GURL& request_url_ = web_contents()->GetLastCommittedURL();
bool is_main_frame = url::Origin(request_url_)
.IsSameOriginWith(url::Origin(request->GetOrigin()));
@@ -419,8 +419,6 @@ void PermissionRequestManager::FinalizeBubble() {
accept_states_.clear();
if (queued_requests_.size() || queued_frame_requests_.size())
TriggerShowBubble();
- else
- request_url_ = GURL();
}
void PermissionRequestManager::CancelPendingQueues() {
« no previous file with comments | « chrome/browser/permissions/permission_request_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698