Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2856353002: Fix DefaultApps unit test (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DefaultApps unit test This disables safe ARC icon decoding which requires IPC. TEST=Test passes. BUG=709297 Review-Url: https://codereview.chromium.org/2856353002 Cr-Commit-Position: refs/heads/master@{#469248} Committed: https://chromium.googlesource.com/chromium/src/+/8e5c71bb45953bfbbcbb49f1124a33ed47d02763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
khmel
Hi Mike, PTAL Thanks!
3 years, 7 months ago (2017-05-04 00:22:01 UTC) #2
msw
lgtm
3 years, 7 months ago (2017-05-04 00:50:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856353002/1
3 years, 7 months ago (2017-05-04 02:17:43 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:31:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e5c71bb45953bfbbcbb49f1124a...

Powered by Google App Engine
This is Rietveld 408576698