Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2856313002: ONC: Do not display errors when parsing empty EAP.EAP fields (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ONC: Do not display errors when parsing empty EAP.EAP fields The change in https://codereview.chromium.org/2853563002 introduced some extra log spam. BUG=380937 Review-Url: https://codereview.chromium.org/2856313002 Cr-Commit-Position: refs/heads/master@{#469161} Committed: https://chromium.googlesource.com/chromium/src/+/498380fe20d70b04b19bd6863576b342ffdf8396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stevenjb
3 years, 7 months ago (2017-05-03 21:28:50 UTC) #2
tbarzic
lgtm
3 years, 7 months ago (2017-05-03 21:33:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856313002/1
3 years, 7 months ago (2017-05-03 21:35:09 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:17:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/498380fe20d70b04b19bd6863576...

Powered by Google App Engine
This is Rietveld 408576698