Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2856303002:
Roll SwiftShader 35e0ba7..5f72693 (Closed)
|
Created:
3 years, 7 months ago by capn Modified:
3 years, 7 months ago Reviewers:
Corentin Wallez CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll SwiftShader 35e0ba7..5f72693
https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693
This mainly switches from using Subzero from DEPS to a copy from a Git subtree.
BUG=
TBR=kbr@chromium.org
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2856303002
Cr-Commit-Position: refs/heads/master@{#469262}
Committed: https://chromium.googlesource.com/chromium/src/+/6bca4ad57bed7c589a558fcb66c5cbff5b981798
Patch Set 1 #Messages
Total messages: 14 (10 generated)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll SwiftShader 35e0ba7..5f72693 https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693 BUG=, https://code.google.com/p/nativeclient/issues/detail?id=4129, //code.google.com/p/nativeclient/issues/detail?id=3894, https://codereview.chromium.org/873443004/,https://code.google.com/p/nativecl..., https://code.google.com/p/nativeclient/issues/detail?id=4290,https://bugs.chr..., https://bugs.chromium.org/p/nativeclient/issues/detail?id=4364, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4365, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4366, None, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363, https://code.google.com/p/nativeclient/issues/detail?id=4076, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4369, https://code.google.com/p/nativeclient/issues/detail?id=4261, https://code.google.com/p/nativeclient/issues/detail?id=4260, https://code.google.com/p/nativeclient/issues/detail?id=4195, https://code.google.com/p/nativeclient/issues/detail?id=4119, https://code.google.com/p/nativeclient/issues/detail?id=3878, https://code.google.com/p/nativeclient/issues/detail?id=3892, https://code.google.com/p/nativeclient/issues/detail?id=4006, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4359, Windows build is sad,build subzero on the bots, none, https://code.google.com/p/nativeclient/issues/detail?id=3903, https://code.google.com/p/nativeclient/issues/detail?id=4329,NONE, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4136,None, https://code.google.com/p/nativeclient/issues/detail?id=4079, https://code.google.com/p/nativeclient/issues/detail?id=4075, https://code.google.com/p/nativeclient/issues/detail?id=4076, https://code.google.com/p/nativeclient/issues/detail?id=4077, https://code.google.com/p/nativeclient/issues/detail?id=3857, https://code.google.com/p/nativeclient/issues/detail?id=3882, https://codereview.chromium.org/512933006/, https://code.google.com/p/nativeclient/issues/detail?id=4080, https://code.google.com/p/nativeclient/issues/detail?id=4083, https://code.google.com/p/nativeclient/issues/detail?id=4085, https://code.google.com/p/nativeclient/issues/detail?id=4084,build failure, https://code.google.com/p/nativeclient/issues/detail?id=4167, https://code.google.com/p/nativeclient/issues/detail?id=4313, https://code.google.com/p/nativeclient/issues/detail?id=4162, https://code.google.com/p/nativeclient/issues/detail?id=4163, https://codereview.chromium.org/296053008/, https://code.google.com/p/nativeclient/issues/detail?id=4316, https://code.google.com/p/nativeclient/issues/detail?id=4319, https://code.google.com/p/nativeclient/issues/detail?id=4169,https://bugs.chr..., https://code.google.com/p/nativeclient/issues/detail?id=4026, https://code.google.com/p/nativeclient/issues/detail?id=4002, https://code.google.com/p/nativeclient/issues/detail?id=4256, https://code.google.com/p/nativeclient/issues/detail?id=4257, https://code.google.com/p/nativeclient/issues/detail?id=4092, https://code.google.com/p/nativeclient/issues/detail?id=4091, https://code.google.com/p/nativeclient/issues/detail?id=4097, https://code.google.com/p/nativeclient/issues/detail?id=4095,https://code.goo..., https://code.google.com/p/nativeclient/issues/detail?id=389, https://code.google.com/p/nativeclient/issues/detail?id=4302, https://code.google.com/p/nativeclient/issues/detail?id=4301, https://code.google.com/p/nativeclient/issues/detail?id=4307, https://code.google.com/p/nativeclient/issues/detail?id=4304, https://code.google.com/p/nativeclient/issues/detail?id=4309, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4327,https://bugs.c..., https://bugs.chromium.org/p/nativeclient/issues/detail?id=4095, https://code.google.com/p/nativeclient/issues/detail?id=3930,https: //code.google.com/p/nativeclient/issues/detail?id=3894,none, b/30502279,none (mini cleanup),https://code.google.com/p/nativeclient/issues/detail?id=4077, https://code.google.com/p/nativeclient/issues/detail?id=4222,https://bugs.chr..., https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55382, https://code.google.com/p/nativeclient/issues/detail?id=4334, https://code.google.com/p/nativeclient/issues/detail?id=4029, https://code.google.com/p/nativeclient/issues/detail?id=4330,https://code.goo..., https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4384, https://code.google.com/p/nativeclient/issues/detail?id=4315, https://code.google.com/p/nativeclient/issues/detail?id=3897, https://code.google.com/p/nativeclient/issues/detail?id=3894, https://code.google.com/p/nativeclient/issues/detail?id=4138, https://code.google.com/p/nativeclient/issues/detail?id=3882, https://code.google.com/p/nativeclient/issues/detail?id=4320, https://code.google.com/p/nativeclient/issues/detail?id=4321, https://code.google.com/p/nativeclient/issues/detail?id=4133, https://code.google.com/p/nativeclient/issues/detail?id=4135, https://code.google.com/p/nativeclient/issues/detail?id=4325, https://code.google.com/p/nativeclient/issues/detail?id=4326,chromium:630728, https://codereview.chromium.org/385273002/, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4370, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4379, https://code.google.com/p/nativeclient/issues/detail?id=4214, https://code.google.com/p/nativeclient/issues/detail?id=4212, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076, https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Merge branch 'master' of https://chromium.googlesource.com/chromium/src Merge branch 'master' of https://chromium.googlesource.com/chromium/src Roll SwiftShader dc7759c..35e0ba7 https://swiftshader.googlesource.com/SwiftShader.git/+log/dc7759c..35e0ba7 Use pthread mutexes on Linux instead of custom spin lock. Fixes compilation issue. BUG=chromium:714412 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll SwiftShader 35e0ba7..5f72693 https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
capn@chromium.org changed reviewers: + cwallez@chromium.org - kbr@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll SwiftShader 35e0ba7..5f72693 https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll SwiftShader 35e0ba7..5f72693 https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693 This mainly switches from using Subzero from DEPS to a copy from a Git subtree. BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
PTAL
The CQ bit was checked by cwallez@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493868785740810, "parent_rev":
"c0731ddc92cb329119dd4988ad306ce590df1bae", "commit_rev":
"6bca4ad57bed7c589a558fcb66c5cbff5b981798"}
Message was sent while issue was closed.
Description was changed from ========== Roll SwiftShader 35e0ba7..5f72693 https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693 This mainly switches from using Subzero from DEPS to a copy from a Git subtree. BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll SwiftShader 35e0ba7..5f72693 https://swiftshader.googlesource.com/SwiftShader.git/+log/35e0ba7..5f72693 This mainly switches from using Subzero from DEPS to a copy from a Git subtree. BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2856303002 Cr-Commit-Position: refs/heads/master@{#469262} Committed: https://chromium.googlesource.com/chromium/src/+/6bca4ad57bed7c589a558fcb66c5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6bca4ad57bed7c589a558fcb66c5... |
