Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2856283003: Adding more deps to webkit-layout-tests on Windows. (Closed)

Created:
3 years, 7 months ago by mithro
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding more deps to webkit-layout-tests on Windows. * Adding perl (needed for CGI scripts). * cygwin (possibly needed?) BUG=717347 TBR=mcgreevy@chromium.org,dpranke@chromium.org Review-Url: https://codereview.chromium.org/2856283003 Cr-Commit-Position: refs/heads/master@{#469297} Committed: https://chromium.googlesource.com/chromium/src/+/1b05bbd2767a86f2a54b8dbf091aaf3c389842c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856283003/1
3 years, 7 months ago (2017-05-04 08:53:02 UTC) #5
mithro
3 years, 7 months ago (2017-05-04 08:53:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1b05bbd2767a86f2a54b8dbf091aaf3c389842c3
3 years, 7 months ago (2017-05-04 09:30:58 UTC) #10
Dirk Pranke
3 years, 7 months ago (2017-05-04 23:45:12 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698