Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2856273002: Legacy block should be positioned with the respect to clearance (Closed)

Created:
3 years, 7 months ago by Gleb Lanbin
Modified:
3 years, 7 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Legacy block should be positioned with the respect to clearance BUG=636993 Review-Url: https://codereview.chromium.org/2856273002 Cr-Commit-Position: refs/heads/master@{#469154} Committed: https://chromium.googlesource.com/chromium/src/+/751f4066f23faba74c281e94203a9771c8aeccad

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 6 chunks +21 lines, -9 lines 2 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Gleb Lanbin
3 years, 7 months ago (2017-05-03 19:43:59 UTC) #3
ikilpatrick
lgtm https://codereview.chromium.org/2856273002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2856273002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode370 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:370: const NGConstraintSpace* child_space, can you also switch this ...
3 years, 7 months ago (2017-05-03 20:08:23 UTC) #5
Gleb Lanbin
thanks for the review. https://codereview.chromium.org/2856273002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2856273002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode370 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:370: const NGConstraintSpace* child_space, On 2017/05/03 ...
3 years, 7 months ago (2017-05-03 20:14:23 UTC) #8
ikilpatrick
https://codereview.chromium.org/2856273002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2856273002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode357 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:357: {border_and_padding_.inline_start + curr_child_margins_.inline_start, sorry just saw this - is ...
3 years, 7 months ago (2017-05-03 20:38:36 UTC) #9
Gleb Lanbin
https://codereview.chromium.org/2856273002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2856273002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode357 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:357: {border_and_padding_.inline_start + curr_child_margins_.inline_start, On 2017/05/03 20:38:36, ikilpatrick wrote: > ...
3 years, 7 months ago (2017-05-03 21:51:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856273002/20001
3 years, 7 months ago (2017-05-03 21:59:39 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:06:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/751f4066f23faba74c281e94203a...

Powered by Google App Engine
This is Rietveld 408576698