Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: media/base/android/mock_android_overlay.h

Issue 2856253004: removed AndroidOverlayFactory (Closed)
Patch Set: cl feedvback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/mock_android_overlay.h
diff --git a/media/base/android/mock_android_overlay.h b/media/base/android/mock_android_overlay.h
index e6d97280b70a9f447aae6f57e7836437412ac13a..a841e9fecba47d0be8441152042ff9bf0ce40fb2 100644
--- a/media/base/android/mock_android_overlay.h
+++ b/media/base/android/mock_android_overlay.h
@@ -27,7 +27,7 @@ class MockAndroidOverlay : public testing::StrictMock<AndroidOverlay>,
// Set |config_|. Sometimes, it's convenient to do this after construction,
// especially if one must create the overlay before the factory provides it
// via CreateOverlay. That's helpful to set test expectations.
- void SetConfig(const Config& config);
+ void SetConfig(AndroidOverlayConfig config);
// Set of callbacks that we provide to control the overlay once you've handed
// off ownership of it. Will return false if the overlay has been destroyed.
@@ -52,7 +52,7 @@ class MockAndroidOverlay : public testing::StrictMock<AndroidOverlay>,
void OnSurfaceDestroyed();
// Initial configuration, mostly for callbacks.
- Config config_;
+ std::unique_ptr<AndroidOverlayConfig> config_;
base::WeakPtrFactory<MockAndroidOverlay> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698