Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: media/base/android/mock_android_overlay.cc

Issue 2856253004: removed AndroidOverlayFactory (Closed)
Patch Set: cl feedvback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/mock_android_overlay.cc
diff --git a/media/base/android/mock_android_overlay.cc b/media/base/android/mock_android_overlay.cc
index 240497ea845b3de5461cb44e5e991ec17c734708..98afca5294988f3ae4b1304e1c8ba8f5b668b533 100644
--- a/media/base/android/mock_android_overlay.cc
+++ b/media/base/android/mock_android_overlay.cc
@@ -5,6 +5,7 @@
#include "media/base/android/mock_android_overlay.h"
#include "base/bind.h"
+#include "base/memory/ptr_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace media {
@@ -17,8 +18,8 @@ MockAndroidOverlay::MockAndroidOverlay() : weak_factory_(this) {}
MockAndroidOverlay::~MockAndroidOverlay() {}
-void MockAndroidOverlay::SetConfig(const Config& config) {
- config_ = config;
+void MockAndroidOverlay::SetConfig(AndroidOverlayConfig config) {
+ config_ = base::MakeUnique<AndroidOverlayConfig>(std::move(config));
}
MockAndroidOverlay::Callbacks MockAndroidOverlay::GetCallbacks() {
@@ -34,15 +35,15 @@ MockAndroidOverlay::Callbacks MockAndroidOverlay::GetCallbacks() {
}
void MockAndroidOverlay::OnOverlayReady() {
- config_.ready_cb.Run(this);
+ config_->is_ready(this);
}
void MockAndroidOverlay::OnOverlayFailed() {
- config_.failed_cb.Run(this);
+ config_->is_failed(this);
}
void MockAndroidOverlay::OnSurfaceDestroyed() {
- config_.destroyed_cb.Run(this);
+ config_->is_destroyed(this);
}
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698