Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 285623004: Add check to make sure the production code is not calling a function in test namespace (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Daniel Erat
Visibility:
Public.

Description

Add check to make sure to make surethe production code is not calling a function in test namespace BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270300

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
6 years, 7 months ago (2014-05-13 00:55:56 UTC) #1
M-A Ruel
lgtm assuming the current code pass this check.
6 years, 7 months ago (2014-05-13 01:17:48 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-14 02:02:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/285623004/20001
6 years, 7 months ago (2014-05-14 02:02:26 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 02:06:10 UTC) #5
Message was sent while issue was closed.
Change committed as 270300

Powered by Google App Engine
This is Rietveld 408576698