PRESUBMIT.py - Issue 285623004: Add check to make sure the production code is not calling a function in test namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 285623004: Add check to make sure the production code is not calling a function in test namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index e9cd21303bb70414b7292d61367980bf5fec69db..271f938b8979eebcb3c123acbba32c46a6fb7a95 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -278,9 +278,9 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):

# calls to such functions without a proper C++ parser.

file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS

- base_function_pattern = r'ForTest(ing)?|for_test(ing)?'

+ base_function_pattern = r'[ :]test::[^\s]+|ForTest(ing)?|for_test(ing)?'

inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern)

- comment_pattern = input_api.re.compile(r'//.*%s' % base_function_pattern)

+ comment_pattern = input_api.re.compile(r'//.*(%s)' % base_function_pattern)

exclusion_pattern = input_api.re.compile(

r'::[A-Za-z0-9_]+(%s)|(%s)[^;]+\{' % (

base_function_pattern, base_function_pattern))

« no previous file with comments | « no previous file | no next file » | no next file with comments »