Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2856223008: Keep Lite Page bit set (Closed)

Created:
3 years, 7 months ago by megjablon
Modified:
3 years, 7 months ago
Reviewers:
nasko, sclittle
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep Lite Page bit set Since Lite Page fallback will not be done via the client, client Lo-Fi should not be shown if a Lite Page was requested. Do not clear the Lite Page bit. BUG=719055 Review-Url: https://codereview.chromium.org/2856223008 Cr-Commit-Position: refs/heads/master@{#470090} Committed: https://chromium.googlesource.com/chromium/src/+/c487f12607e6cde6cbe17854013e355a18e71b5d

Patch Set 1 #

Patch Set 2 : update fallback integration test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -49 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/chrome_proxy/webdriver/lite_page.py View 1 3 chunks +5 lines, -41 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
megjablon
Sclittle, PTAL. Do you have a bug I can link to?
3 years, 7 months ago (2017-05-05 21:35:39 UTC) #4
sclittle
LGTM, thanks for doing this. I filed a crbug and assigned it to you: https://bugs.chromium.org/p/chromium/issues/detail?id=719055
3 years, 7 months ago (2017-05-05 22:15:39 UTC) #5
megjablon
nasko: content
3 years, 7 months ago (2017-05-05 22:19:53 UTC) #8
nasko
Rubberstamp LGTM
3 years, 7 months ago (2017-05-08 17:12:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856223008/20001
3 years, 7 months ago (2017-05-08 19:21:25 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 19:57:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c487f12607e6cde6cbe17854013e...

Powered by Google App Engine
This is Rietveld 408576698