Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2856203005: Use constexpr TaskTraits constructor in android_webview. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, Tobias Sargeant
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in android_webview. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in android_webview. BUG=713683 R=gab@chromium.org TBR=tobiasjs@chromium.org Review-Url: https://codereview.chromium.org/2856203005 Cr-Commit-Position: refs/heads/master@{#469114} Committed: https://chromium.googlesource.com/chromium/src/+/054e8f0ade030ca9d679cdfafaacd6d2f2e97617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:14:33 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:14:36 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:25:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856203005/1
3 years, 7 months ago (2017-05-03 20:30:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856203005/1
3 years, 7 months ago (2017-05-03 20:44:33 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 20:58:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/054e8f0ade030ca9d679cdfafaac...

Powered by Google App Engine
This is Rietveld 408576698