Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2856193002: Update global interface listing for web payments API on desktop. (Closed)

Created:
3 years, 7 months ago by please use gerrit instead
Modified:
3 years, 7 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, mac-reviews_chromium.org, lunalu1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update global interface listing for web payments API on desktop. This patch updates the global interface listing after PaymentRequest was enabled on additional platforms: Windows, Mac, ChromeOS, Linux. blink-dev@ announcement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/p1DYoxHlkKg/g_ZW1YLDCgAJ This patch also re-enables global interface listing tests, which should never be disabled. BUG=717914 Review-Url: https://codereview.chromium.org/2856193002 Cr-Commit-Position: refs/heads/master@{#469497} Committed: https://chromium.googlesource.com/chromium/src/+/259bce9e315438c00d7d660b446de65b6b03c360

Patch Set 1 #

Messages

Total messages: 15 (8 generated)
please use gerrit instead
Rick, ptal.
3 years, 7 months ago (2017-05-03 15:25:08 UTC) #3
Rick Byers
Thanks for taking care of this quickly! PaymentRequest is enabled on Linux too, right? Don't ...
3 years, 7 months ago (2017-05-04 21:08:20 UTC) #7
Rick Byers
Regardless if this passes the bots then LGTM (IIRC Linux will actually use the win ...
3 years, 7 months ago (2017-05-04 21:13:19 UTC) #8
Rick Byers
I guess the reason this broke the build and got disabled is that it was ...
3 years, 7 months ago (2017-05-04 21:14:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856193002/1
3 years, 7 months ago (2017-05-04 21:16:42 UTC) #11
please use gerrit instead
Yes, the API is enabled on Linux as well. It's passing with the patch, so ...
3 years, 7 months ago (2017-05-04 21:17:28 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:50:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/259bce9e315438c00d7d660b446d...

Powered by Google App Engine
This is Rietveld 408576698