Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2856183002: Fix timeout for mus_browsertests/mash_browsertests (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix timeout for mus_browsertests/mash_browsertests Two problems here: . timeout is in seconds, not minutes. . hard_timeout needs to be inside the swarming block, otherwise it's not used at all. BUG=none TEST=none R=rockot@chromium.org TBR=rockot@chromium.org Review-Url: https://codereview.chromium.org/2856183002 Cr-Commit-Position: refs/heads/master@{#469231} Committed: https://chromium.googlesource.com/chromium/src/+/ffc595bc81b4a23043061b5b34c66c8a4ab06612

Patch Set 1 #

Total comments: 1

Patch Set 2 : 900 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sky
3 years, 7 months ago (2017-05-03 15:17:11 UTC) #1
sky
I'm TBRing this given we spoke about it in the office.
3 years, 7 months ago (2017-05-03 15:41:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856183002/1
3 years, 7 months ago (2017-05-03 15:41:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/375636)
3 years, 7 months ago (2017-05-03 16:35:07 UTC) #7
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2856183002/diff/1/testing/buildbot/chromium.chromiumos.json File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/2856183002/diff/1/testing/buildbot/chromium.chromiumos.json#newcode256 testing/buildbot/chromium.chromiumos.json:256: "hard_timeout": 90 900? :) Though if we think ...
3 years, 7 months ago (2017-05-03 17:43:24 UTC) #8
Ken Rockot(use gerrit already)
On 2017/05/03 at 17:43:24, Ken Rockot wrote: > lgtm > > https://codereview.chromium.org/2856183002/diff/1/testing/buildbot/chromium.chromiumos.json > File testing/buildbot/chromium.chromiumos.json ...
3 years, 7 months ago (2017-05-03 17:43:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856183002/20001
3 years, 7 months ago (2017-05-04 00:13:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ffc595bc81b4a23043061b5b34c66c8a4ab06612
3 years, 7 months ago (2017-05-04 01:25:31 UTC) #15
sky
3 years, 7 months ago (2017-05-04 02:18:19 UTC) #16
Message was sent while issue was closed.
On 2017/05/03 17:43:24, Ken Rockot wrote:
> lgtm
> 
>
https://codereview.chromium.org/2856183002/diff/1/testing/buildbot/chromium.c...
> File testing/buildbot/chromium.chromiumos.json (right):
> 
>
https://codereview.chromium.org/2856183002/diff/1/testing/buildbot/chromium.c...
> testing/buildbot/chromium.chromiumos.json:256: "hard_timeout": 90
> 900? :)
> 
> Though if we think we can get mash_browser_tests completing in 90 seconds I'm
> all for it!

Fixed!

Powered by Google App Engine
This is Rietveld 408576698