Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2856133002: Local NTP: Allow iframes from *.google.com (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
fhorschig
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Local NTP: Allow iframes from *.google.com if OneGoogleBarOnLocalNtp is enabled. This achieves two things: - More robust if things change server-side - Allows staging instances BUG=583292 Review-Url: https://codereview.chromium.org/2856133002 Cr-Commit-Position: refs/heads/master@{#468933} Committed: https://chromium.googlesource.com/chromium/src/+/8758b479e0b41c9311ded11ef2a2d4ffd4d59d4c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/search/local_ntp_source.cc View 1 chunk +2 lines, -5 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
Marc Treib
PTAL!
3 years, 7 months ago (2017-05-03 10:16:27 UTC) #6
fhorschig
lgtm https://codereview.chromium.org/2856133002/diff/1/chrome/browser/search/local_ntp_source.cc File chrome/browser/search/local_ntp_source.cc (left): https://codereview.chromium.org/2856133002/diff/1/chrome/browser/search/local_ntp_source.cc#oldcode438 chrome/browser/search/local_ntp_source.cc:438: chrome::kChromeSearchMostVisitedUrl); As discussed offline, please point this out ...
3 years, 7 months ago (2017-05-03 10:41:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856133002/1
3 years, 7 months ago (2017-05-03 10:43:55 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 10:47:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8758b479e0b41c9311ded11ef2a2...

Powered by Google App Engine
This is Rietveld 408576698