Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2856113002: CollectionViewTextItem should copy accessibilityLabel to the cell (Closed)

Created:
3 years, 7 months ago by vabr (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CollectionViewTextItem should copy accessibilityLabel to the cell Currently, the accessibilityLabel for the CollectionViewTextCell is always composed from the text and detailText attributes. Instead, if present, accessibilityLabel on the item should be copied over to the cell. BUG=717864 Review-Url: https://codereview.chromium.org/2856113002 Cr-Commit-Position: refs/heads/master@{#468918} Committed: https://chromium.googlesource.com/chromium/src/+/887ed4b568cf6c67608c9838fef4be47fb962fd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm View 1 chunk +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_text_item_unittest.mm View 3 chunks +33 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi lpromero@, Please review. Thanks! Vaclav
3 years, 7 months ago (2017-05-03 06:48:36 UTC) #4
lpromero
lgtm
3 years, 7 months ago (2017-05-03 08:17:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856113002/1
3 years, 7 months ago (2017-05-03 08:17:48 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 08:21:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/887ed4b568cf6c67608c9838fef4...

Powered by Google App Engine
This is Rietveld 408576698