Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2856103002: [turbofan] Introduce dedicated CallFrequency class. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce dedicated CallFrequency class. When we don't know the call count for a given call site (i.e. for inlined accessors), we put 0 as call frequency so far. But as of https://codereview.chromium.org/2859433002, this would completely disable the inlining of those calls, since 0 is interpreted as never called, which is not what we want. So instead of defaulting to 0, add a dedicated sentinel, whose value is NaN, which makes the call site eligible for inlining, but not high priority (as it was before the CL mentioned above). BUG=v8:4493, v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2856103002 Cr-Commit-Position: refs/heads/master@{#45053} Committed: https://chromium.googlesource.com/v8/v8/+/23ee74310b2d1aab30e1be3ae1fdba8850357734

Patch Set 1 #

Patch Set 2 : Address offline feedback from jarin@. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -60 lines) Patch
M src/compiler/ast-graph-builder.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 5 chunks +11 lines, -8 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 4 chunks +7 lines, -5 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining-heuristic.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 4 chunks +13 lines, -10 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/js-operator.h View 1 7 chunks +43 lines, -10 lines 0 comments Download
M src/compiler/js-operator.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-03 05:58:10 UTC) #1
Jarin
lgtm
3 years, 7 months ago (2017-05-03 09:51:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856103002/20001
3 years, 7 months ago (2017-05-03 09:54:55 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 09:57:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/23ee74310b2d1aab30e1be3ae1fdba88503...

Powered by Google App Engine
This is Rietveld 408576698