Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2856073002: Chrome Cleaner: Move files to correct directory (Closed)

Created:
3 years, 7 months ago by alito
Modified:
3 years, 7 months ago
Reviewers:
msw, csharp, mattm
CC:
chromium-reviews, vakh+watch_chromium.org, joenotcharles+watch_chromium.org, tfarina, grt+watch_chromium.org, timvolodine, csharp+watch_chromium.org, alito+watch_chromium.org, ftirelo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome Cleaner: Move files to correct directory BUG= Review-Url: https://codereview.chromium.org/2856073002 Cr-Commit-Position: refs/heads/master@{#469036} Committed: https://chromium.googlesource.com/chromium/src/+/bc28b9160d36fd044d9dc669e6b7642715a21530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -140 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/safe_browsing/chrome_cleaner_dialog_controller.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/safe_browsing/chrome_cleaner_dialog_controller.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/ui/views/chrome_cleaner_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_cleaner_dialog_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
alito
Just moving a couple of files to new location. Owners, PTAL: csharp@: chrome/browser/safe_browsing/chrome_cleaner mattm@: chrome/browser/safe_browsing/ ...
3 years, 7 months ago (2017-05-03 15:38:53 UTC) #6
msw
c/b/ui/views lgtm
3 years, 7 months ago (2017-05-03 17:28:07 UTC) #7
mattm
lgtm
3 years, 7 months ago (2017-05-03 17:48:28 UTC) #8
csharp
lgtm
3 years, 7 months ago (2017-05-03 18:13:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856073002/1
3 years, 7 months ago (2017-05-03 18:16:21 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:21:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc28b9160d36fd044d9dc669e6b7...

Powered by Google App Engine
This is Rietveld 408576698