Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2856053005: Fix case issues in a wpt test module/execorder.html (Closed)

Created:
3 years, 7 months ago by hiroshige
Modified:
3 years, 7 months ago
Reviewers:
module-dev, kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix case issues in a wpt test module/execorder.html The actual filenames are all lowercase, but src attributes in execorder.html contains uppercase letters. This causes the scripts not found and thus timeouts on Linux (which runs on a case-sensitive filesystem). This CL fixes the timeout by making the src attributes all lowercased. BUG=594639 Review-Url: https://codereview.chromium.org/2856053005 Cr-Commit-Position: refs/heads/master@{#469519} Committed: https://chromium.googlesource.com/chromium/src/+/78cbcd5cd4e8022b18067c522e66f2fa1d02ba8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/execorder.html View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
hiroshige
PTAL.
3 years, 7 months ago (2017-05-04 21:57:57 UTC) #8
hiroshige
PTAL.
3 years, 7 months ago (2017-05-04 22:01:51 UTC) #10
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-05-04 23:23:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856053005/1
3 years, 7 months ago (2017-05-04 23:24:53 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:32:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78cbcd5cd4e8022b18067c522e66...

Powered by Google App Engine
This is Rietveld 408576698