Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.h

Issue 2856033002: Add finch control of user population in low reputation requests (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.h
diff --git a/components/safe_browsing/password_protection/password_protection_service.h b/components/safe_browsing/password_protection/password_protection_service.h
index e0470ccaa0daa3139eaf96114533c271ccffa15a..9963266b9a2aa492022c74e50060627d7935ee31 100644
--- a/components/safe_browsing/password_protection/password_protection_service.h
+++ b/components/safe_browsing/password_protection/password_protection_service.h
@@ -8,6 +8,7 @@
#include <set>
#include "base/callback.h"
+#include "base/feature_list.h"
#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -32,6 +33,9 @@ namespace safe_browsing {
class SafeBrowsingDatabaseManager;
class PasswordProtectionRequest;
+extern const base::Feature kLowReputationPinging;
+extern const base::Feature kProtectedPasswordEntryPinging;
+
// Manage password protection pings and verdicts. There is one instance of this
// class per profile. Therefore, every PasswordProtectionService instance is
// associated with a unique HistoryService instance and a unique
@@ -116,11 +120,17 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
int event_tab_id, // -1 if tab id is not available.
LoginReputationClientRequest::Frame* frame) = 0;
+ void FillUserPopulation(
+ const LoginReputationClientRequest::TriggerType& request_type,
+ LoginReputationClientRequest* request_proto);
+
virtual bool IsExtendedReporting() = 0;
+
virtual bool IsIncognito() = 0;
- // If we can send ping to Safe Browsing backend.
- virtual bool IsPingingEnabled() = 0;
+ virtual bool IsPingingEnabled(const base::Feature& feature) = 0;
+
+ virtual bool IsHistorySyncEnabled() = 0;
void CheckCsdWhitelistOnIOThread(const GURL& url, bool* check_result);
@@ -128,6 +138,8 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
// metric based on input.
void OnMatchCsdWhiteListResult(const bool* match_whitelist);
+ HostContentSettingsMap* content_settings() const { return content_settings_; }
+
private:
friend class PasswordProtectionServiceTest;
friend class TestPasswordProtectionService;

Powered by Google App Engine
This is Rietveld 408576698