Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.cc

Issue 2856033002: Add finch control of user population in low reputation requests (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.cc
diff --git a/components/safe_browsing/password_protection/password_protection_request.cc b/components/safe_browsing/password_protection/password_protection_request.cc
index 2827ed46d5687c72e762317505473644e40c8ada..4a1f36f352ad4ddc8bd76b7ce303a3cdcd19356d 100644
--- a/components/safe_browsing/password_protection/password_protection_request.cc
+++ b/components/safe_browsing/password_protection/password_protection_request.cc
@@ -41,17 +41,6 @@ PasswordProtectionRequest::~PasswordProtectionRequest() {
void PasswordProtectionRequest::Start() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- // Initially we only send ping for Safe Browsing Extended Reporting users when
- // they are not in incognito mode. We may loose these conditions later.
- if (password_protection_service_->IsIncognito()) {
- Finish(RequestOutcome::INCOGNITO, nullptr);
- return;
- }
- if (!password_protection_service_->IsExtendedReporting()) {
- Finish(RequestOutcome::NO_EXTENDED_REPORTING, nullptr);
- return;
- }
-
CheckWhitelistOnUIThread();
}
@@ -97,6 +86,8 @@ void PasswordProtectionRequest::FillRequestProto() {
request_proto_ = base::MakeUnique<LoginReputationClientRequest>();
request_proto_->set_page_url(main_frame_url_.spec());
request_proto_->set_trigger_type(request_type_);
+ password_protection_service_->FillUserPopulation(request_type_,
+ request_proto_.get());
request_proto_->set_stored_verdict_cnt(
password_protection_service_->GetStoredVerdictCount());
LoginReputationClientRequest::Frame* main_frame =

Powered by Google App Engine
This is Rietveld 408576698