[doc] fix doc to work in all known repos.

[doc] fix doc to work in all known repos.

R=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2856003002
Committed: https://github.com/luci/recipes-py/commit/a582c6db898c82dec83aeb353431fc51d62591e6

[iannucci, 2017-05-02 23:39:02]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:39:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 23:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 23:44:16]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35e459cd9ede7d10)

[iannucci, 2017-05-02 23:46:47]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:46:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-05-02 23:48:40]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:48:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 23:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 23:51:16]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-05-03 00:05:34]

https://codereview.chromium.org/2856003002/diff/40001/recipe_engine/doc.py
File recipe_engine/doc.py (right):

https://codereview.chromium.org/2856003002/diff/40001/recipe_engine/doc.py#ne...
recipe_engine/doc.py:77: isinstance(node.targets[0], ast.Name) and
There are other sorts of nodes which can show up in assignments, such as
Subscripts, e.g.:
  foo[0] = "something"

https://codereview.chromium.org/2856003002/diff/40001/recipe_engine/doc.py#ne...
recipe_engine/doc.py:181: KNOWN_OBJECTS.update(_recipe_api_class_imports)
This change allows the 'known_objects' section of the doc proto to contain
documentation for ALL known types.

https://codereview.chromium.org/2856003002/diff/40001/recipe_engine/doc.py#ne...
recipe_engine/doc.py:483: _add_it(key, fname, node.value.id)
This is necessary for some of the type aliases in config.py.

https://codereview.chromium.org/2856003002/diff/40001/recipe_engine/recipe_ap...
File recipe_engine/recipe_api.py (right):

https://codereview.chromium.org/2856003002/diff/40001/recipe_engine/recipe_ap...
recipe_engine/recipe_api.py:1003: raise TypeError('default=%r is not
json-encodable' % (default,))
These changes are to assert that any Property defined by a recipe or module only
provides default values which are actually json-compatible. This is generally
true, but apparently depot_tools has one instance where it provides a FrozenDict
as a default value.

[iannucci, 2017-05-03 00:05:47]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 00:05:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:08:47]

Dry run: This issue passed the CQ dry run.

[dnj, 2017-05-03 00:25:31]

lgtm

https://codereview.chromium.org/2856003002/diff/60001/recipe_engine/doc.py
File recipe_engine/doc.py (right):

https://codereview.chromium.org/2856003002/diff/60001/recipe_engine/doc.py#ne...
recipe_engine/doc.py:494: #   Target = RealImplementation
Actually this was real nice. It took a few minutes to shift my brain into full
AST mode. Would you mind adding comments to each of these "ast.*" sections w/ an
example of what that section is doing in Python? I think that would speed up the
context switch.

[iannucci, 2017-05-03 01:09:11]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 01:09:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-05-03 01:09:31]

https://codereview.chromium.org/2856003002/diff/60001/recipe_engine/doc.py
File recipe_engine/doc.py (right):

https://codereview.chromium.org/2856003002/diff/60001/recipe_engine/doc.py#ne...
recipe_engine/doc.py:494: #   Target = RealImplementation
On 2017/05/03 00:25:31, dnj wrote:
> Actually this was real nice. It took a few minutes to shift my brain into full
> AST mode. Would you mind adding comments to each of these "ast.*" sections w/
an
> example of what that section is doing in Python? I think that would speed up
the
> context switch.

Done.

[iannucci, 2017-05-03 01:10:08]

The CQ bit was unchecked by iannucci@chromium.org

[iannucci, 2017-05-03 01:10:08]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-05-03 01:10:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2856003002/#ps80001
(title: "add comments")

[commit-bot: I haz the power, 2017-05-03 01:10:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 01:12:56]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493773808930180,
"parent_rev": "af7abb5d24a477ca062c054034fe6b5cd44f17c5", "commit_rev":
"a582c6db898c82dec83aeb353431fc51d62591e6"}

[commit-bot: I haz the power, 2017-05-03 01:13:00]

Description was changed from

==========
[doc] fix doc to work in all known repos.

R=dnj@chromium.org
BUG=
==========

to

==========
[doc] fix doc to work in all known repos.

R=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2856003002
Committed:
https://github.com/luci/recipes-py/commit/a582c6db898c82dec83aeb353431fc51d62...
==========

[commit-bot: I haz the power, 2017-05-03 01:13:01]

Committed patchset #5 (id:80001) as
https://github.com/luci/recipes-py/commit/a582c6db898c82dec83aeb353431fc51d62...