Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2855983002: Consider Button clicks for extension notifications (Closed)

Created:
3 years, 7 months ago by Miguel Garcia
Modified:
3 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider Button clicks for extension notifications BUG=716782 Review-Url: https://codereview.chromium.org/2855983002 Cr-Commit-Position: refs/heads/master@{#468836} Committed: https://chromium.googlesource.com/chromium/src/+/e5d0ff4df4be89a8ec26ab26d7d468a54c294616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/notifications/non_persistent_notification_handler.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Miguel Garcia
3 years, 7 months ago (2017-05-02 22:48:25 UTC) #3
Peter Beverloo
lgtm
3 years, 7 months ago (2017-05-03 00:25:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855983002/1
3 years, 7 months ago (2017-05-03 00:25:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 00:31:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5d0ff4df4be89a8ec26ab26d7d4...

Powered by Google App Engine
This is Rietveld 408576698