Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2855943004: [MD settings] split protocol handler tests from site tests (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] split protocol handler tests from site tests This CL separates the site settings protocol handler tests from the site settings test. This is a step toward a code health todo in the code. (code health) BUG=None Review-Url: https://codereview.chromium.org/2855943004 Cr-Commit-Position: refs/heads/master@{#469039} Committed: https://chromium.googlesource.com/chromium/src/+/a46aab2f99e966682624213c0c267280d3f90db4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -132 lines) Patch
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 3 chunks +24 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/protocol_handlers_tests.js View 3 chunks +124 lines, -130 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dschuyler
This is trying to help with the TODO here https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cr_settings_browsertest.js?type=cs&q=%22TODO(dbeam)%22+file:test&l=798 https://codereview.chromium.org/2855943004/diff/1/chrome/test/data/webui/settings/protocol_handlers_tests.js File chrome/test/data/webui/settings/protocol_handlers_tests.js (right): https://codereview.chromium.org/2855943004/diff/1/chrome/test/data/webui/settings/protocol_handlers_tests.js#newcode5 ...
3 years, 7 months ago (2017-05-03 00:42:42 UTC) #4
Dan Beam
makes sense, lgtm
3 years, 7 months ago (2017-05-03 00:45:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855943004/1
3 years, 7 months ago (2017-05-03 18:25:42 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:34:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a46aab2f99e966682624213c0c26...

Powered by Google App Engine
This is Rietveld 408576698