Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2855933002: Only include base/win/windows_version.h on Windows build (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), Mads Ager (chromium), vmpstr+watch_chromium.org, wfh+watch_chromium.org, oilpan-reviews, danakj+watch_chromium.org, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only include base/win/windows_version.h on Windows build I ran check_gn_headers.py on linux and android full builds and manually fixed it. BUG=661774 Review-Url: https://codereview.chromium.org/2855933002 Cr-Commit-Position: refs/heads/master@{#468848} Committed: https://chromium.googlesource.com/chromium/src/+/2f8d9b469f243f117f37ec929920f33bf61eb40a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/allocator/partition_allocator/address_space_randomization.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-02 20:45:17 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-03 00:44:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855933002/1
3 years, 7 months ago (2017-05-03 00:59:37 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 01:06:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f8d9b469f243f117f37ec929920...

Powered by Google App Engine
This is Rietveld 408576698