Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2855923002: [Payments] Desktop: enable the Payment Request integration by default (Closed)

Created:
3 years, 7 months ago by Mathieu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tfarina, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Desktop: enable the Payment Request integration by default The WebPayments feature flag is now ENABLED_BY_DEFAULT, and on the renderer side the feature is enabled based on the same feature. See blink-dev intent to ship update here: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/Payment$20Request%7Csort:relevance/blink-dev/p1DYoxHlkKg/0mP2L5cyBQAJ BUG=717660 TEST=existing Review-Url: https://codereview.chromium.org/2855923002 Cr-Commit-Position: refs/heads/master@{#468845} Committed: https://chromium.googlesource.com/chromium/src/+/0ea8510a570b6556ea40679bb03b64a5fdcc7550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/payments/site_per_process_payments_browsertest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Mathieu
Rouslan, PTAL before I include owners, thanks!
3 years, 7 months ago (2017-05-02 19:09:58 UTC) #3
please use gerrit instead
lgtm
3 years, 7 months ago (2017-05-02 20:11:34 UTC) #7
Mathieu
Hi Pavel, PTAL for the content/ changes, thanks.
3 years, 7 months ago (2017-05-02 20:24:17 UTC) #10
pfeldman
lgtm
3 years, 7 months ago (2017-05-02 23:04:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855923002/1
3 years, 7 months ago (2017-05-02 23:39:43 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 00:48:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ea8510a570b6556ea40679bb03b...

Powered by Google App Engine
This is Rietveld 408576698