Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2855913002: Revert of ❄ Split off RadioButtonLayout from InfoBarControls (Closed)

Created:
3 years, 7 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 7 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews, dfalcantara+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ❄ Split off RadioButtonLayout from InfoBarControls (patchset #4 id:60001 of https://codereview.chromium.org/2850063002/ ) Reason for revert: Newly introduced test is failing on some builders, see http://crbug.com/717651 BUG=717651 Original issue's description: > ❄ Split off RadioButtonLayout from InfoBarControls > > Changes to the Infobar spec and how they lay out controls are coming. > Split off radio buttons into a separate layout that InfoBarControls > use and can be added by other layouts to prevent conflating changes > between them. > > Also fixes up how the promo dialog (which used the RadioButtons) > assigns widths to some of its children. > > Screenshots: > https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDYkxiQWNwS1JzR2c > > BUG=712836, 712833 > > Review-Url: https://codereview.chromium.org/2850063002 > Cr-Commit-Position: refs/heads/master@{#468494} > Committed: https://chromium.googlesource.com/chromium/src/+/2883e4221128cdc2b95aa765031ab77b9b4f5794 TBR=twellington@chromium.org,dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=712836, 712833 Review-Url: https://codereview.chromium.org/2855913002 Cr-Commit-Position: refs/heads/master@{#468720} Committed: https://chromium.googlesource.com/chromium/src/+/b07af8134668d9c752a45d48003eaf322c03c550

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
aelias_OOO_until_Jul13
Created Revert of ❄ Split off RadioButtonLayout from InfoBarControls
3 years, 7 months ago (2017-05-02 18:48:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855913002/1
3 years, 7 months ago (2017-05-02 18:49:29 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:50:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b07af8134668d9c752a45d48003e...

Powered by Google App Engine
This is Rietveld 408576698