Don't send activation event when created

Don't send activation event when created

The new task may be already created on Android side, which
can deactivate a new task on Android side. This CL suppresses
the activation event for creation as well as activation request.

R=reveman@chromium.org
BUG=718429
TEST=Run cts test "CtsUiHostTestCases". It no longer fails.

Review-Url: https://codereview.chromium.org/2855883009
Cr-Commit-Position: refs/heads/master@{#469823}
Committed: https://chromium.googlesource.com/chromium/src/+/67679038561e87a38508710c0058477333b40eac

[oshima, 2017-05-04 14:20:28]

Patchset #1 (id:1) has been deleted

[oshima, 2017-05-04 14:20:32]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 14:20:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 14:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 14:48:20]

Dry run: This issue passed the CQ dry run.

[reveman, 2017-05-04 15:10:52]

I prefer if we keep this logic in server.cc and limited to remote_shell
surfaces. Can we instead set this property to true initially for remote shell
surfaces and then clear it in that code after the window has initially become
visible?

[oshima, 2017-05-04 15:12:41]

On 2017/05/04 15:10:52, reveman wrote:
> I prefer if we keep this logic in server.cc and limited to remote_shell
> surfaces. Can we instead set this property to true initially for remote shell
> surfaces and then clear it in that code after the window has initially become
> visible?

ok, will do.

[oshima, 2017-05-05 15:43:59]

PTAL

[reveman, 2017-05-05 18:04:29]

https://codereview.chromium.org/2855883009/diff/40001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2855883009/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:268:
window->SetProperty(kIgnoreWindowActivated, false);
Can we use an aura::WindowObserver for this instead? Create and add it when the
remote shell surfaces is created? Maybe set it to false when
OnWindowVisibilityChanged is called. That would keep this workaround nicely
separated from non remote-shell code that doesn't need it.

[oshima, 2017-05-05 23:09:33]

https://codereview.chromium.org/2855883009/diff/40001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2855883009/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:268:
window->SetProperty(kIgnoreWindowActivated, false);
On 2017/05/05 18:04:29, reveman wrote:
> Can we use an aura::WindowObserver for this instead? Create and add it when
the
> remote shell surfaces is created? Maybe set it to false when
> OnWindowVisibilityChanged is called. That would keep this workaround nicely
> separated from non remote-shell code that doesn't need it.

The window becomes visible before being activated when created,
so this won't work.

But I found a better way. We can just reset the flag on activation. PTAL

https://codereview.chromium.org/2855883009/diff/40001/components/exo/wayland/...
components/exo/wayland/server.cc:1952:
window->SetProperty(kIgnoreWindowActivated, false);
we still need this because activation may fail

[reveman, 2017-05-05 23:27:13]

Nice! lgtm

[oshima_google, 2017-05-05 23:42:58]

The CQ bit was checked by oshima@google.com

[commit-bot: I haz the power, 2017-05-05 23:44:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 00:13:19]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494027778845950,
"parent_rev": "ec11daa13a86c2535a123ea45e91e5b82d4d7d1e", "commit_rev":
"67679038561e87a38508710c0058477333b40eac"}

[commit-bot: I haz the power, 2017-05-06 00:14:22]

Description was changed from

==========
Don't send activation event when created

The new task may be already created on Android side, which
can deactivate a new task on Android side. This CL suppresses
the activation event for creation as well as activation request.

R=reveman@chromium.org
BUG=718429
TEST=Run cts test "CtsUiHostTestCases". It no longer fails.
==========

to

==========
Don't send activation event when created

The new task may be already created on Android side, which
can deactivate a new task on Android side. This CL suppresses
the activation event for creation as well as activation request.

R=reveman@chromium.org
BUG=718429
TEST=Run cts test "CtsUiHostTestCases". It no longer fails.

Review-Url: https://codereview.chromium.org/2855883009
Cr-Commit-Position: refs/heads/master@{#469823}
Committed:
https://chromium.googlesource.com/chromium/src/+/67679038561e87a38508710c0058...
==========

[commit-bot: I haz the power, 2017-05-06 00:14:23]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/67679038561e87a38508710c0058...