Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2855883005: cros: Selectively fork login assets. (Closed)

Created:
3 years, 7 months ago by jdufault
Modified:
3 years, 7 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Selectively fork login assets. This CL forks login code which is most likely to change with the new UI. This allows us to make breaking changes to the login screen without worrying about the previous UI. This adds an `isMd` boolean variable in the global scope that can be dynamically queried if we need to make changes in a file and it is not trivial to fork it. Otherwise, there are no code changes besides loading different assets. BUG=717779 NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2855883005 Cr-Commit-Position: refs/heads/master@{#469026} Committed: https://chromium.googlesource.com/chromium/src/+/ca8e8754a8180b41aa6afff69cfd8ef35e11d5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6665 lines, -4 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/md_login.html View 1 chunk +19 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/md_login.js View 1 chunk +3 lines, -1 line 0 comments Download
A chrome/browser/resources/chromeos/login/md_login_screens.html View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/md_login_shared.html View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/md_login_shared.js View 1 chunk +470 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/md_screen_container.html View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_screen_account_picker.css View 1 chunk +74 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_screen_account_picker.html View 1 chunk +9 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_screen_account_picker.js View 1 chunk +476 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_user_pod_row.css View 1 chunk +1024 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_user_pod_row.js View 1 chunk +3984 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_user_pod_template.css View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/login/account_picker/md_user_pod_template.html View 1 chunk +216 lines, -0 lines 0 comments Download
A ui/login/md_screen_container.css View 1 chunk +258 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
jdufault
alemate@ PTAL. There should be very few actual code changes. Thanks
3 years, 7 months ago (2017-05-02 23:21:36 UTC) #10
jdufault
alemate@ PTAL. There should be very few actual code changes. Thanks
3 years, 7 months ago (2017-05-02 23:21:37 UTC) #11
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-02 23:33:39 UTC) #12
jdufault
xiyuan@ PTAL at browser_resources.grd
3 years, 7 months ago (2017-05-02 23:36:54 UTC) #14
xiyuan
browser_resources.grd lgtm
3 years, 7 months ago (2017-05-03 03:57:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855883005/1
3 years, 7 months ago (2017-05-03 16:43:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/426425)
3 years, 7 months ago (2017-05-03 16:52:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855883005/1
3 years, 7 months ago (2017-05-03 17:39:19 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:40:40 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca8e8754a8180b41aa6afff69cfd...

Powered by Google App Engine
This is Rietveld 408576698