Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2855883002: [ios] Revert of History didReceiveQueryResult performBatchUpdates. (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Revert of History didReceiveQueryResult performBatchUpdates. This reverts: https://codereview.chromium.org/2800473004/ Since it increased the crash rate as in bug 716349. BUG=716349 Review-Url: https://codereview.chromium.org/2855883002 Cr-Commit-Position: refs/heads/master@{#468856} Committed: https://chromium.googlesource.com/chromium/src/+/4575e0c18c3fea30e4f59ccc4c00fca6e6014698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -44 lines) Patch
M ios/chrome/browser/ui/history/history_collection_view_controller.mm View 5 chunks +27 lines, -44 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sczs
PTAL
3 years, 7 months ago (2017-05-02 17:46:30 UTC) #3
lpromero
lgtm
3 years, 7 months ago (2017-05-02 17:51:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855883002/1
3 years, 7 months ago (2017-05-03 00:53:27 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 01:21:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4575e0c18c3fea30e4f59ccc4c00...

Powered by Google App Engine
This is Rietveld 408576698