Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2855783003: Fix dependencies on deprecated webrtc videoframe features. (Closed)

Created:
3 years, 7 months ago by nisse-chromium (ooo August 14)
Modified:
3 years, 7 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dependencies on deprecated webrtc videoframe features. Needed for reland of https://codereview.webrtc.org/2622263002/ BUG=webrtc:5880 Review-Url: https://codereview.chromium.org/2855783003 Cr-Commit-Position: refs/heads/master@{#468603} Committed: https://chromium.googlesource.com/chromium/src/+/252666c9c21919c74b0cbf1c4893f0aecfa41798

Patch Set 1 #

Patch Set 2 : Add missing gn dependency on video_frame_api. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/renderer/media/gpu/rtc_video_encoder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
nisse-chromium (ooo August 14)
PTAL. Are you still willing to review Chrome changes?
3 years, 7 months ago (2017-05-02 07:10:11 UTC) #2
perkj_chrome
sure lgtm
3 years, 7 months ago (2017-05-02 07:51:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855783003/1
3 years, 7 months ago (2017-05-02 09:55:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/443134)
3 years, 7 months ago (2017-05-02 09:59:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855783003/20001
3 years, 7 months ago (2017-05-02 10:52:26 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 11:56:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/252666c9c21919c74b0cbf1c4893...

Powered by Google App Engine
This is Rietveld 408576698