Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 2855773002: [Remoting iOS] Adjust position and height of HostCollectionView (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss, Jamie
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting iOS] Adjust position and height of HostCollectionView Previously the first host item in the host list is always overlayed by the navigation bar, making it impossible to select the first host. This CL adjusts the position and height of HostCollectionView to fix this problem. BUG=716697 Review-Url: https://codereview.chromium.org/2855773002 Cr-Commit-Position: refs/heads/master@{#468824} Committed: https://chromium.googlesource.com/chromium/src/+/8157c6553d38a82e2fd2d35053626d034420242b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M remoting/client/ios/app/remoting_view_controller.mm View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yuwei
PTAL Thanks!
3 years, 7 months ago (2017-05-01 23:48:24 UTC) #2
nicholss
lgtm
3 years, 7 months ago (2017-05-02 23:44:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855773002/1
3 years, 7 months ago (2017-05-02 23:45:04 UTC) #5
Jamie
Rubber-stamp LGTM since OWNERS is pending for Scott.
3 years, 7 months ago (2017-05-02 23:49:28 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:57:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8157c6553d38a82e2fd2d3505362...

Powered by Google App Engine
This is Rietveld 408576698