Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855693002:
Reporting: Don't crash in ~ProfileIOData without URLRequestContextStorage (Closed)
|
Created:
3 years, 7 months ago by Julia Tuttle Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReporting: Don't crash in ~ProfileIOData without URLRequestContextStorage
BUG=717183
Review-Url: https://codereview.chromium.org/2855693002
Cr-Commit-Position: refs/heads/master@{#468650}
Committed: https://chromium.googlesource.com/chromium/src/+/2d76b52e99c335398b390d2009188d7a4037bd97
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
juliatuttle@chromium.org changed reviewers: + shivanisha@chromium.org
PTAL, shivanisha.
On 2017/05/01 at 19:11:45, juliatuttle wrote: > PTAL, shivanisha. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by juliatuttle@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
juliatuttle@chromium.org changed reviewers: + mmenke@chromium.org
PTAL at //chrome/browser/profiles, mmenke.
On 2017/05/02 14:12:02, Julia Tuttle wrote: > PTAL at //chrome/browser/profiles, mmenke. LGTM. Find it bizarre that we have all this code for a path that is never tested with unit tests, only encountered in production. (I'd write one, but I don't understand what path this is)
On 2017/05/02 15:04:37, mmenke wrote: > On 2017/05/02 14:12:02, Julia Tuttle wrote: > > PTAL at //chrome/browser/profiles, mmenke. > > LGTM. Find it bizarre that we have all this code for a path that is never > tested with unit tests, only encountered in production. (I'd write one, but I > don't understand what path this is) You mean the "URLRequestContext is never created" path? We could probably test it.
The CQ bit was checked by juliatuttle@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493740044230870, "parent_rev":
"8c67c0c97b32e34ec7a1ecc8fa403ba9e4b12231", "commit_rev":
"2d76b52e99c335398b390d2009188d7a4037bd97"}
Message was sent while issue was closed.
Description was changed from ========== Reporting: Don't crash in ~ProfileIOData without URLRequestContextStorage BUG=717183 ========== to ========== Reporting: Don't crash in ~ProfileIOData without URLRequestContextStorage BUG=717183 Review-Url: https://codereview.chromium.org/2855693002 Cr-Commit-Position: refs/heads/master@{#468650} Committed: https://chromium.googlesource.com/chromium/src/+/2d76b52e99c335398b390d200918... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2d76b52e99c335398b390d200918...
Message was sent while issue was closed.
On 2017/05/02 15:47:15, Julia Tuttle wrote: > On 2017/05/02 15:04:37, mmenke wrote: > > On 2017/05/02 14:12:02, Julia Tuttle wrote: > > > PTAL at //chrome/browser/profiles, mmenke. > > > > LGTM. Find it bizarre that we have all this code for a path that is never > > tested with unit tests, only encountered in production. (I'd write one, but I > > don't understand what path this is) > > You mean the "URLRequestContext is never created" path? We could probably test > it. Correct. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
