Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855683002:
Remove getImageDataColorManaged performance test (Closed)
|
Created:
3 years, 7 months ago by zakerinasab Modified:
3 years, 7 months ago Reviewers:
Justin Novosad CC:
chromium-reviews, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove getImageDataColorManaged performance test
getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail on perf bots. Removing the test for now. crbug.com/717549 is filed for follow up.
BUG=717080
Review-Url: https://codereview.chromium.org/2855683002
Cr-Original-Commit-Position: refs/heads/master@{#468416}
Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a94afe11ace92
Review-Url: https://codereview.chromium.org/2855683002
Cr-Commit-Position: refs/heads/master@{#468661}
Committed: https://chromium.googlesource.com/chromium/src/+/c7ea169be1422d47ffb14c5ba443ee4fb986650f
Patch Set 1 #Patch Set 2 : Removing the test for now #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 ========== to ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 ==========
zakerinasab@chromium.org changed reviewers: + junov@chromium.org
lgtm
The CQ bit was checked by zakerinasab@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493664739145620, "parent_rev":
"bd2c9c2adb7a29f623798f53b4001f70c9681cb1", "commit_rev":
"89ac4eb510183e617a186af25a4a94afe11ace92"}
Message was sent while issue was closed.
Description was changed from ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 ========== to ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a...
Message was sent while issue was closed.
Description was changed from ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ========== to ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ==========
The CQ bit was checked by zakerinasab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/2855683002/#ps20001 (title: "Removing the test for now")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/01 21:31:07, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... I removed the perf test for now to prevent perf try bots from failing. The new createImageBitmap API is behind a flag. I'll add the correct test in another CL.
Description was changed from ========== Fix getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ========== to ========== Remove getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail. Removing the test for now. crbug.com/717549 is filed for follow up. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ==========
Description was changed from ========== Remove getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail. Removing the test for now. crbug.com/717549 is filed for follow up. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ========== to ========== Remove getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail on perf bots. Removing the test for now. crbug.com/717549 is filed for follow up. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ==========
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493737068457540,
"parent_rev": "376186504c93feac078435f1620005d15609974f", "commit_rev":
"c7ea169be1422d47ffb14c5ba443ee4fb986650f"}
Message was sent while issue was closed.
Description was changed from ========== Remove getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail on perf bots. Removing the test for now. crbug.com/717549 is filed for follow up. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... ========== to ========== Remove getImageDataColorManaged performance test getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail on perf bots. Removing the test for now. crbug.com/717549 is filed for follow up. BUG=717080 Review-Url: https://codereview.chromium.org/2855683002 Cr-Original-Commit-Position: refs/heads/master@{#468416} Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a... Review-Url: https://codereview.chromium.org/2855683002 Cr-Commit-Position: refs/heads/master@{#468661} Committed: https://chromium.googlesource.com/chromium/src/+/c7ea169be1422d47ffb14c5ba443... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c7ea169be1422d47ffb14c5ba443... |
