Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855583003:
Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 (Closed)
|
Created:
3 years, 7 months ago by Kai Ninomiya Modified:
3 years, 7 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0
This was seen on Sony Xperia Z5 (Adreno 430).
BUG=696126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2855583003
Cr-Commit-Position: refs/heads/master@{#468507}
Committed: https://chromium.googlesource.com/chromium/src/+/586c01de3897c0aa2d9911ff703c51595cf22f62
Patch Set 1 #
Total comments: 6
Patch Set 2 : merge new gpu_driver_bug_list entry into an old one #
Total comments: 2
Patch Set 3 : update os version in software rendering list #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 BUG=696126 ========== to ========== Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 BUG=696126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 BUG=696126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 This was seen on Sony Xperia Z5 (Adreno 430). BUG=696126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kainino@chromium.org changed reviewers: + kbr@chromium.org
kbr: PTAL
lgtm, couple questions. Sorry about the linux_optional_gpu_tests_rel failure; being dealt with in https://codereview.chromium.org/2853133002/ . https://codereview.chromium.org/2855583003/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2855583003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list.json:2381: "comment": "Corresponds to software rendering list entry #147", Could you also point to entry 174, above? They seem related. https://codereview.chromium.org/2855583003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list.json:2388: "value": "7.0" Do you think it's worth expanding this to "between" 7.0.0 and 7.0.99, per entry 174 in this file? https://codereview.chromium.org/2855583003/diff/1/gpu/config/software_renderi... File gpu/config/software_rendering_list.json (right): https://codereview.chromium.org/2855583003/diff/1/gpu/config/software_renderi... gpu/config/software_rendering_list.json:1583: "value": "7.0" Same question about using the "=" vs. "between" operator.
https://codereview.chromium.org/2855583003/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2855583003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list.json:2381: "comment": "Corresponds to software rendering list entry #147", On 2017/05/01 22:52:19, Ken Russell wrote: > Could you also point to entry 174, above? They seem related. I'm actually going to merge these two entries. They are probably the same bug. https://codereview.chromium.org/2855583003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list.json:2388: "value": "7.0" On 2017/05/01 22:52:19, Ken Russell wrote: > Do you think it's worth expanding this to "between" 7.0.0 and 7.0.99, per entry > 174 in this file? Done. https://codereview.chromium.org/2855583003/diff/1/gpu/config/software_renderi... File gpu/config/software_rendering_list.json (right): https://codereview.chromium.org/2855583003/diff/1/gpu/config/software_renderi... gpu/config/software_rendering_list.json:1583: "value": "7.0" On 2017/05/01 22:52:19, Ken Russell wrote: > Same question about using the "=" vs. "between" operator. Done.
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2855583003/diff/20001/gpu/config/software_ren... File gpu/config/software_rendering_list.json (right): https://codereview.chromium.org/2855583003/diff/20001/gpu/config/software_ren... gpu/config/software_rendering_list.json:1583: "value": "7.0" Still should use the same "op" as driver bug #174.
The CQ bit was unchecked by kainino@chromium.org
https://codereview.chromium.org/2855583003/diff/20001/gpu/config/software_ren... File gpu/config/software_rendering_list.json (right): https://codereview.chromium.org/2855583003/diff/20001/gpu/config/software_ren... gpu/config/software_rendering_list.json:1583: "value": "7.0" On 2017/05/01 23:11:00, Ken Russell wrote: > Still should use the same "op" as driver bug #174. Done, thanks for catching this.
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/01 23:15:18, Kai Ninomiya wrote: > https://codereview.chromium.org/2855583003/diff/20001/gpu/config/software_ren... > File gpu/config/software_rendering_list.json (right): > > https://codereview.chromium.org/2855583003/diff/20001/gpu/config/software_ren... > gpu/config/software_rendering_list.json:1583: "value": "7.0" > On 2017/05/01 23:11:00, Ken Russell wrote: > > Still should use the same "op" as driver bug #174. > > Done, thanks for catching this. No problem. Still LGTM.
The CQ bit was unchecked by kainino@chromium.org
The CQ bit was checked by kainino@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493681773140860,
"parent_rev": "7ad715177d4c4950a979fcbaad584b75fad11853", "commit_rev":
"586c01de3897c0aa2d9911ff703c51595cf22f62"}
Message was sent while issue was closed.
Description was changed from ========== Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 This was seen on Sony Xperia Z5 (Adreno 430). BUG=696126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0 This was seen on Sony Xperia Z5 (Adreno 430). BUG=696126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2855583003 Cr-Commit-Position: refs/heads/master@{#468507} Committed: https://chromium.googlesource.com/chromium/src/+/586c01de3897c0aa2d9911ff703c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/586c01de3897c0aa2d9911ff703c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
