Fix ComputedStyleBase.h.tmpl to generate accessors for fields on groups

Fix ComputedStyleBase.h.tmpl to generate accessors for fields on groups

This patch fixes the jinja templates to generate accessors for fields on
groups. It then uses the generated accessors in ComputedStyle.h

https://gist.github.com/nainar/f2816c46b990a49db3e2c3990cc9cdb1/revisions

BUG=710938
Review-Url: https://codereview.chromium.org/2855583002
Cr-Commit-Position: refs/heads/master@{#468912}
Committed: https://chromium.googlesource.com/chromium/src/+/c8be5e3666ee8a9afcd174f28d1ff49101fe5636

[nainar, 2017-05-01 05:55:44]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 05:55:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-01 07:33:52]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-01 07:33:53]

shend@, 

PTAL? Thanks!

[nainar, 2017-05-01 07:35:37]

Description was changed from

==========
Fix ComputedStyleBase.h.tmpl to generate accessors for fields on groups

This patch fixes the jinja templates to generate accessors for fields on
groups. It then uses the generated accessors in ComputedStyle.h

BUG=710938
==========

to

==========
Fix ComputedStyleBase.h.tmpl to generate accessors for fields on groups

This patch fixes the jinja templates to generate accessors for fields on
groups. It then uses the generated accessors in ComputedStyle.h

https://gist.github.com/nainar/f2816c46b990a49db3e2c3990cc9cdb1/revisions

BUG=710938
==========

[shend, 2017-05-01 07:36:49]

lgtm, thanks Naina!

[nainar, 2017-05-01 07:37:21]

nainar@chromium.org changed reviewers:
+ meade@chromium.org

[nainar, 2017-05-01 07:37:22]

meade, 

PTAL? Thanks!

[commit-bot: I haz the power, 2017-05-01 07:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 07:38:59]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-05-03 03:14:26]

lgtm

[nainar, 2017-05-03 03:15:01]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-05-03 03:15:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 03:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 03:18:34]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-03 04:29:11]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 04:29:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 04:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 04:40:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nainar, 2017-05-03 04:53:28]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 04:53:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 06:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 06:54:32]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-05-03 06:55:43]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-05-03 06:55:43]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2855583002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-03 06:55:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 06:59:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493794543407420,
"parent_rev": "faf6b1e5ba15004aec259c817b75509df9639c88", "commit_rev":
"c8be5e3666ee8a9afcd174f28d1ff49101fe5636"}

[commit-bot: I haz the power, 2017-05-03 06:59:38]

Description was changed from

==========
Fix ComputedStyleBase.h.tmpl to generate accessors for fields on groups

This patch fixes the jinja templates to generate accessors for fields on
groups. It then uses the generated accessors in ComputedStyle.h

https://gist.github.com/nainar/f2816c46b990a49db3e2c3990cc9cdb1/revisions

BUG=710938
==========

to

==========
Fix ComputedStyleBase.h.tmpl to generate accessors for fields on groups

This patch fixes the jinja templates to generate accessors for fields on
groups. It then uses the generated accessors in ComputedStyle.h

https://gist.github.com/nainar/f2816c46b990a49db3e2c3990cc9cdb1/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2855583002
Cr-Commit-Position: refs/heads/master@{#468912}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8be5e3666ee8a9afcd174f28d1f...
==========

[commit-bot: I haz the power, 2017-05-03 06:59:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c8be5e3666ee8a9afcd174f28d1f...