Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2855543003: Use TaskScheduler instead of WorkerPool in print_job.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, gene
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in print_job.cc. WorkerPool is being deprecated in favor of TaskScheduler. BUG=659191 Review-Url: https://codereview.chromium.org/2855543003 Cr-Commit-Position: refs/heads/master@{#469192} Committed: https://chromium.googlesource.com/chromium/src/+/c76a60b8acefc4672c60799d0a9b5e4d2b242c65

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/printing/print_job.cc View 1 2 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-01 21:05:46 UTC) #7
fdoray
+thestig@: PTAL (gene@ does't seem to be working on Chrome anymore)
3 years, 7 months ago (2017-05-03 16:38:29 UTC) #13
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-03 21:10:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855543003/40001
3 years, 7 months ago (2017-05-03 21:35:11 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:20:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c76a60b8acefc4672c60799d0a9b...

Powered by Google App Engine
This is Rietveld 408576698