Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2855533002: Fix missing headers about vpn service (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing headers about vpn service Decreased the number of missing header files by 1. BUG=661774 Review-Url: https://codereview.chromium.org/2855533002 Cr-Commit-Position: refs/heads/master@{#468512} Committed: https://chromium.googlesource.com/chromium/src/+/e4e376d3183be96ccb95b1e0fd8f4d648a54775b

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert chrome/browser/ui/ash/system_tray_client.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/browser/browser_context_keyed_service_factories.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-01 06:00:18 UTC) #6
jam
https://codereview.chromium.org/2855533002/diff/1/chrome/browser/ui/ash/system_tray_client.cc File chrome/browser/ui/ash/system_tray_client.cc (right): https://codereview.chromium.org/2855533002/diff/1/chrome/browser/ui/ash/system_tray_client.cc#newcode55 chrome/browser/ui/ash/system_tray_client.cc:55: #if defined(OS_CHROMEOS) system_tray_client.cc is only in chromeos builds, so ...
3 years, 7 months ago (2017-05-01 21:23:19 UTC) #7
wychen
https://codereview.chromium.org/2855533002/diff/1/chrome/browser/ui/ash/system_tray_client.cc File chrome/browser/ui/ash/system_tray_client.cc (right): https://codereview.chromium.org/2855533002/diff/1/chrome/browser/ui/ash/system_tray_client.cc#newcode55 chrome/browser/ui/ash/system_tray_client.cc:55: #if defined(OS_CHROMEOS) On 2017/05/01 21:23:19, jam wrote: > system_tray_client.cc ...
3 years, 7 months ago (2017-05-01 23:18:21 UTC) #9
jam
lgtm
3 years, 7 months ago (2017-05-01 23:47:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855533002/20001
3 years, 7 months ago (2017-05-01 23:49:57 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:46:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e4e376d3183be96ccb95b1e0fd8f...

Powered by Google App Engine
This is Rietveld 408576698