Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

Issue 2855503003: Replace uses of legacy SkBitmap::copyTo() API (Closed)
Patch Set: Fix paren errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc
index ae08305aba940c292907ab7a805d06327fb85ce2..70cc717c7f46bbe2d41578f2e22484b71e16c35e 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc
@@ -81,12 +81,12 @@ class AccessibilityHighlightManagerTest : public InProcessBrowserTest {
void CaptureBeforeImage(const gfx::Rect& bounds) {
Capture(bounds);
- image_.AsBitmap().deepCopyTo(&before_bmp_);
+ image_.asLegacyBitmap(&before_bmp_, SkImage::kRW_LegacyBitmapMode);
f(malita) 2017/05/01 18:00:06 asLegacyBitmap() doesn't copy the pixels for raste
msarett1 2017/05/01 18:04:55 I think that using kRW_LegacyBitmapMode will force
f(malita) 2017/05/01 18:36:01 Ah yeah, indeed. It does feel a bit fragile/incid
msarett1 2017/05/01 19:53:50 Agreed, yeah it is. I've changed the impl to allo
}
void CaptureAfterImage(const gfx::Rect& bounds) {
Capture(bounds);
- image_.AsBitmap().deepCopyTo(&after_bmp_);
+ image_.asLegacyBitmap(&after_bmp_, SkImage::kRW_LegacyBitmapMode);
f(malita) 2017/05/01 18:00:06 Ditto.
}
void ComputeImageStats() {

Powered by Google App Engine
This is Rietveld 408576698