Replace uses of legacy SkBitmap::copyTo() API

chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h"
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
@@ skipping 63 matching lines @@
     AccessibilityFocusRingController::GetInstance()->SetNoFadeForTesting();
     InProcessBrowserTest::SetUp();
   }
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitch(::switches::kEnablePixelOutputInTests);
   }
 
   void CaptureBeforeImage(const gfx::Rect& bounds) {
     Capture(bounds);
-    image_.AsBitmap().deepCopyTo(&before_bmp_);
+    image_.asLegacyBitmap(&before_bmp_, SkImage::kRW_LegacyBitmapMode);

[f(malita), 2017/05/01 18:00:06]

asLegacyBitmap() doesn't copy the pixels for raster SkImages, so these are not
equivalent, no?

Depending on the test semantics, this may break.

[msarett1, 2017/05/01 18:04:55]

I think that using kRW_LegacyBitmapMode will force a copy.  Regardless, this
might be confusing.  What do you think?

[f(malita), 2017/05/01 18:36:01]

Ah yeah, indeed.  It does feel a bit fragile/incidental, but LGTM for a test.

Maybe add a comment to explain that we're forcing a deep copy.

[msarett1, 2017/05/01 19:53:50]

Agreed, yeah it is.  I've changed the impl to alloc() and readPixels()

   }
 
   void CaptureAfterImage(const gfx::Rect& bounds) {
     Capture(bounds);
-    image_.AsBitmap().deepCopyTo(&after_bmp_);
+    image_.asLegacyBitmap(&after_bmp_, SkImage::kRW_LegacyBitmapMode);

[f(malita), 2017/05/01 18:00:06]

Ditto.

   }
 
   void ComputeImageStats() {
     diff_count_ = 0;
     double accum[4] = {0, 0, 0, 0};
     for (int x = 0; x < before_bmp_.width(); ++x) {
       for (int y = 0; y < before_bmp_.height(); ++y) {
         SkColor before_color = before_bmp_.getColor(x, y);
         SkColor after_color = after_bmp_.getColor(x, y);
         if (before_color != after_color) {
@@ skipping 127 matching lines @@
   // This is a smoke test to assert that something is drawn in the right
   // part of the screen of approximately the right size and color.
   // There's deliberately some tolerance for tiny errors.
   EXPECT_NEAR(1608, diff_count(), 50);
   EXPECT_NEAR(255, SkColorGetR(average_diff_color()), 5);
   EXPECT_NEAR(201, SkColorGetG(average_diff_color()), 5);
   EXPECT_NEAR(152, SkColorGetB(average_diff_color()), 5);
 }
 
 }  // namespace chromeos