Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2855443002: Fix detached event listener attribute updating. (Closed)

Created:
3 years, 7 months ago by sof
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix detached event listener attribute updating. The parser will in some cases create new elements in documents that have become frame-detached. Account for that -- no execution context due to the document having become detached -- when processing the event listeners of an event attribute. R=haraken BUG=714353 Review-Url: https://codereview.chromium.org/2855443002 Cr-Commit-Position: refs/heads/master@{#468294} Committed: https://chromium.googlesource.com/chromium/src/+/3c689934871ad2f934d37938b67e7a3fb2b65987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/events/event-listener-detached.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
sof
please take a look.
3 years, 7 months ago (2017-04-30 05:30:12 UTC) #7
haraken
LGTM
3 years, 7 months ago (2017-04-30 12:21:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855443002/1
3 years, 7 months ago (2017-04-30 15:24:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/442415)
3 years, 7 months ago (2017-04-30 19:56:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855443002/1
3 years, 7 months ago (2017-05-01 05:17:23 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 05:55:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c689934871ad2f934d37938b67e...

Powered by Google App Engine
This is Rietveld 408576698