Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2855423004:
Remove some iOS 9 CQ configurations to reduce load. (Closed)
DescriptionRemove some iOS 9 CQ configurations to reduce load.
During peak load, maximum capacity is reached. Remove redundant
iOS 9 configurations from the CQ and main waterfall. This still
runs tablet, iPhone, 32-bit, and 64-bit on the CQ, it just doesn't
run every combination.
BUG=718524
Review-Url: https://codereview.chromium.org/2855423004
Cr-Commit-Position: refs/heads/master@{#469744}
Committed: https://chromium.googlesource.com/chromium/src/+/2f3ad3b7b77d3a36922e42d3d3e5b1ad08a2a074
Patch Set 1 #
Total comments: 2
Messages
Total messages: 21 (11 generated)
baxley@chromium.org changed reviewers: + rohitrao@chromium.org, sergeyberezin@chromium.org, smut@google.com
baxley@chromium.org changed required reviewers: + rohitrao@chromium.org, sergeyberezin@chromium.org, smut@google.com
I'd like to get everyone's approval to do this. I want to make sure this is actually useful for our capacity issues, and I want to verify that reducing this test coverage is not harmful. I feel this redundant coverage of specific iOS 9 combinations is nice to have, but lower priority than reducing CQ delays or having EG tests. I don't know if it's worth increasing capacity to include all these configuration combinations.
lgtm if this coverage isn't too useful. This removes 14*3 = 42 test suites, most of which are short, but the removal of net_unittests from the three platforms should free up 0.5 bot hours.
sergeyberezin@google.com changed reviewers: + sergeyberezin@google.com
LGTM - I believe it should help the capacity, since it's ~30% of all tests running on this pool.
lgtm https://codereview.chromium.org/2855423004/diff/1/ios/build/bots/chromium.mac... File ios/build/bots/chromium.mac/ios-simulator.json (left): https://codereview.chromium.org/2855423004/diff/1/ios/build/bots/chromium.mac... ios/build/bots/chromium.mac/ios-simulator.json:60: "device type": "iPhone 6s", This is probably our most popular iOS9 configuration, so I'm the most concerned about dropping this one.
https://codereview.chromium.org/2855423004/diff/1/ios/build/bots/chromium.mac... File ios/build/bots/chromium.mac/ios-simulator.json (left): https://codereview.chromium.org/2855423004/diff/1/ios/build/bots/chromium.mac... ios/build/bots/chromium.mac/ios-simulator.json:60: "device type": "iPhone 6s", On 2017/05/05 11:26:55, rohitrao (ping after 24h) wrote: > This is probably our most popular iOS9 configuration, so I'm the most concerned > about dropping this one. Okay, I see two options... 1. Drop iPhone 5 and iPad Air 2 on iOS 9 (keeping iPhone 6s and iPad Retina). 2. Simply keep iPhone 6s, only removing 2 out of the 10 configs. I'd lean towards 1, but am open if there's a compelling reason to keep iPad Air 2 or iPhone 5 on iOS 9.
On 2017/05/05 13:22:18, baxley wrote: > https://codereview.chromium.org/2855423004/diff/1/ios/build/bots/chromium.mac... > File ios/build/bots/chromium.mac/ios-simulator.json (left): > > https://codereview.chromium.org/2855423004/diff/1/ios/build/bots/chromium.mac... > ios/build/bots/chromium.mac/ios-simulator.json:60: "device type": "iPhone 6s", > On 2017/05/05 11:26:55, rohitrao (ping after 24h) wrote: > > This is probably our most popular iOS9 configuration, so I'm the most > concerned > > about dropping this one. > > Okay, I see two options... > 1. Drop iPhone 5 and iPad Air 2 on iOS 9 (keeping iPhone 6s and iPad Retina). > 2. Simply keep iPhone 6s, only removing 2 out of the 10 configs. > > I'd lean towards 1, but am open if there's a compelling reason to keep iPad Air > 2 or iPhone 5 on iOS 9. I'll keep it as is after offline discussion. It's too hard to predict which combination is most likely to catch something that nothing else would catch, and this situation is pretty rare (we don't know if we've encountered it).
The CQ bit was checked by baxley@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Remove some iOS 9 CQ configurations to reduce load. During peak load, maximum capacity is reached. Remove redundant iOS 9 configurations from the CQ and main waterfall. This still runs tablet, iPhone, 32-bit, and 64-bit on the CQ, it just doesn't run every combination. BUG=718524 ========== to ========== Remove some iOS 9 CQ configurations to reduce load. During peak load, maximum capacity is reached. Remove redundant iOS 9 configurations from the CQ and main waterfall. This still runs tablet, iPhone, 32-bit, and 64-bit on the CQ, it just doesn't run every combination. BUG=718524 ==========
baxley@chromium.org changed reviewers: - sergeyberezin@chromium.org
baxley@chromium.org changed required reviewers: - sergeyberezin@chromium.org
The CQ bit was checked by baxley@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494009048605420, "parent_rev":
"78cc3a7cd15dfec03aeafa0aeb2887cb676658dc", "commit_rev":
"2f3ad3b7b77d3a36922e42d3d3e5b1ad08a2a074"}
Message was sent while issue was closed.
Description was changed from ========== Remove some iOS 9 CQ configurations to reduce load. During peak load, maximum capacity is reached. Remove redundant iOS 9 configurations from the CQ and main waterfall. This still runs tablet, iPhone, 32-bit, and 64-bit on the CQ, it just doesn't run every combination. BUG=718524 ========== to ========== Remove some iOS 9 CQ configurations to reduce load. During peak load, maximum capacity is reached. Remove redundant iOS 9 configurations from the CQ and main waterfall. This still runs tablet, iPhone, 32-bit, and 64-bit on the CQ, it just doesn't run every combination. BUG=718524 Review-Url: https://codereview.chromium.org/2855423004 Cr-Commit-Position: refs/heads/master@{#469744} Committed: https://chromium.googlesource.com/chromium/src/+/2f3ad3b7b77d3a36922e42d3d3e5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2f3ad3b7b77d3a36922e42d3d3e5... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
