Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2855423002: Use more StringPieces in the PDF plugin. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use more StringPieces in the PDF plugin. Also use existing values from chrome/common/url_constants.h. Review-Url: https://codereview.chromium.org/2855423002 Cr-Commit-Position: refs/heads/master@{#469453} Committed: https://chromium.googlesource.com/chromium/src/+/470f9de544112af34025ed028c007e27e68b7013

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M pdf/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/out_of_process_instance.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 7 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Lei Zhang
https://codereview.chromium.org/2855423002/diff/1/pdf/out_of_process_instance.h File pdf/out_of_process_instance.h (left): https://codereview.chromium.org/2855423002/diff/1/pdf/out_of_process_instance.h#oldcode207 pdf/out_of_process_instance.h:207: // |dst_page_index| specifies the blank page index that needs ...
3 years, 7 months ago (2017-05-04 19:19:38 UTC) #8
dsinclair
lgtm
3 years, 7 months ago (2017-05-04 19:22:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855423002/20001
3 years, 7 months ago (2017-05-04 20:31:59 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 20:36:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/470f9de544112af34025ed028c00...

Powered by Google App Engine
This is Rietveld 408576698